-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Commitment: partial unfold #11546
Merged
Merged
Commitment: partial unfold #11546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 62ed361.
Added debug env `KV_READ_METRICS=false`. When it's true, we gather Summaries of: ``` kv_get{level="L0"`} kv_get{level="L1"`} kv_get{level="L2"`} kv_get{level="L3"`} kv_get{level="L4"`} kv_get{level="recent"} its a first step to #10691. Have to add per-domain metrics as well. I will cover grafana dashboard a bit later.
This reverts commit 311b7c5.
Giulio2002
approved these changes
Oct 15, 2024
#12259 become unsplittable part of this PR due to intention to have Rebuild along with state memorisation. |
2 tasks
yperbasis
added a commit
that referenced
this pull request
Nov 1, 2024
PR #11546 inadvertently changed the `tests/testdata` submodule
Hi @awskii, could you show the full step to rebuild the commitment? thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
take2 on #11536 #11350
Partial unfold means that we want to skip unfolding of nodes when it's possible to do so.
Node state for account represented by fields [balance/nonce/codeHash] and for storage by it's value.
By default node is not loaded with state. During folding, if needed, state parts are loaded.
Skip is possible in following cases (having memoised state hash already exists):
There is still a Q which state hashes are worth keeping and which are not. In bor experiments we've seen that top-level hashes of storages are changing quite frequently, as well as hashes of accounts with lot's of storage keys in it.
This PR totally reworks mechanism of rebuilding commitment files when all other domains exists and have same ranges.
If cancelled during rebuilt, have to remove all shards which doesn't have matching range to other domains.
In example,
accounts
are [0-1024, 1024-1536, ..] andcommitment
are [0-1024, 1024-1152..] you have to do remove commitment files of steps > 1024 (their range does not match to account 1024-1536, rebuilt will be incorrect and there is no protection yet for that case.To rebuild commitment:
To be done:
integration commitment
along with analysis tool for commitment files.